Skip to content

feat: add cookies.setSerialized to create a cookie from a string #13681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add cookies.setSerialized to create a cookie from a string #13681

wants to merge 14 commits into from

Conversation

while1618
Copy link

@while1618 while1618 commented Apr 4, 2025 •
edited by benmccann
Loading

closes #13680

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13681-svelte.vercel.app/

@while1618 while1618 mentioned this pull request Apr 4, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025 

pnpm add https://pkg.pr.new/@sveltejs/adapter-auto@13681
pnpm add https://pkg.pr.new/@sveltejs/adapter-cloudflare@13681
pnpm add https://pkg.pr.new/@sveltejs/adapter-netlify@13681
pnpm add https://pkg.pr.new/@sveltejs/adapter-static@13681
pnpm add https://pkg.pr.new/@sveltejs/adapter-node@13681
pnpm add https://pkg.pr.new/@sveltejs/adapter-vercel@13681
pnpm add https://pkg.pr.new/@sveltejs/amp@13681
pnpm add https://pkg.pr.new/create-svelte@13681
pnpm add https://pkg.pr.new/@sveltejs/enhanced-img@13681
pnpm add https://pkg.pr.new/@sveltejs/kit@13681
pnpm add https://pkg.pr.new/@sveltejs/package@13681

@eltigerchino eltigerchino linked an issue Apr 7, 2025 that may be closed by this pull request
Create a cookie from a string #13680
Open
@eltigerchino eltigerchino changed the title add new method cookies.setFromString to create a cookie from a string feat: add cookies.setFromString to create a cookie from a string Apr 7, 2025
@eltigerchino eltigerchino added the feature / enhancement New feature or request label Apr 7, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 31de519

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

here is the issue for this PR: #13680

I edited the PR description. If you say "fixes" or "closes" followed by the issue number then GitHub will link the issue and PR

@dummdidumm
Copy link
Member

The thrown errors for validation make me a bit wary of whether want to add this - feels a bit safer to parse the cookie from a string, then set it - that way you're forced to handle this yourself and TypeScript can help you.

@benmccann
Copy link
Member

@dummdidumm it may be my lack of typescript expertise speaking here, but how would typescript help?

@while1618
Copy link
Author

Hey @benmccann, your suggestions make sense to me. Should I just commit them, or should we wait for another maintainer?

@benmccann
Copy link
Member

I don't think there's much harm in adding my suggestions, but we'll need agreement for a larger group of maintainers before deciding whether to accept the PR

@while1618
Copy link
Author

Okay, I'll commit them.

And what is your approach for PRs to be merged? Are we just waiting for enough maintainers to see this or you guys have some email/tag if opinion of others is required?

@while1618 while1618 changed the title feat: add cookies.setFromString to create a cookie from a string feat: add cookies.setSerialized to create a cookie from a string Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@eltigerchino eltigerchino eltigerchino left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature / enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a cookie from a string
4 participants
@while1618 @benmccann @dummdidumm @eltigerchino